Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce api queries #11455

Merged
merged 4 commits into from Feb 27, 2024
Merged

fix: reduce api queries #11455

merged 4 commits into from Feb 27, 2024

Conversation

guanbinrui
Copy link
Member

Description

Closes MF-0000

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@guanbinrui guanbinrui added this to the 2.25.0 milestone Feb 27, 2024
@guanbinrui guanbinrui changed the base branch from develop to hotfix/2.24.6 February 27, 2024 05:53
@guanbinrui guanbinrui marked this pull request as ready for review February 27, 2024 05:53
@guanbinrui guanbinrui merged commit 6be5cf7 into hotfix/2.24.6 Feb 27, 2024
5 of 6 checks passed
@guanbinrui guanbinrui deleted the fix/reduce-api-queries branch February 27, 2024 05:54
Jack-Works
Jack-Works reviewed Feb 27, 2024
View reviewed changes
packages/mask/content-script/site-adaptors/twitter.com/injection/ProfileCover.tsx
@@ -8,10 +8,6 @@ export function injectProfileCover(signal: AbortSignal) {
const watcher = new MutationObserverWatcher(searchProfileCoverSelector())
startWatch(watcher, {
signal,
missingReportRule: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you remove error report?

Jack-Works pushed a commit that referenced this pull request Feb 27, 2024
@guanbinrui @Jack-Works
fix: reduce api queries (#11455)
b11face 
* fix: config queries

* refactor: remove missingReportRule

* refactor: condition rendering

* fix: disabled refetch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-Works Jack-Works Jack-Works left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.25.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guanbinrui @Jack-Works