refactor: avatar plugin #11473

guanbinrui · 2024-03-02T03:42:29Z

Description

Closes MF-6073

Type of change

Documentation
Code refactoring (Restructuring existing code w/o changing its observable behavior)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

My code follows the style guidelines of this project.
I have performed a self-review of my own code.
- I have removed all in development console.logs
- I have removed all commented code.
I have commented on my code, particularly in hard-to-understand areas.
I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

I have configured those APIs with CORS headers to let extension requests get passed.
- chrome extension: chrome-extension://[id]
- firefox extension: moz-extension://[id]
I have delegated all web requests to the background service via the internal RPC bridge.

refactor: remove unused components chore: tidy up components refactor: store helpers chore: impl store refactor: avatar components refactor: cleanup types refactor: remove mobile sniffing

Jack-Works · 2024-04-24T15:08:30Z

packages/web3-shared/base/src/helpers/resolver.ts

+    const indexOf = url.indexOf('?')
+    return url.slice(0, Math.max(0, indexOf === -1 ? url.length : indexOf))


why you don't use new URL()??

CC @UncleBill

Jack-Works · 2024-04-24T15:09:38Z

packages/web3-providers/src/AvatarStore/index.ts

+    private getAvatarToken = memoizePromise(
+        memoize,
+        (userId: string, avatarId?: string, publicKey?: string): Promise<StoreItem | null> => {
+            return requestIdleCallbackAsync(async () => {


what will happen if you don't use this requestIdleCallback? why do you need it?

The result of the callback function doesn't need to be used immediately.

The result of the callback function doesn't need to be used immediately.

sorry can you clarify? I don't understand

I created a data hub to store avatar records. It accepts data fetch requests from the UI in various places. When it receives a request, it fetches data when the browser is idle, because the quantity of requests might be quite high. I don't want this task to block the UI.

but you are not queueing them. so it will block the UI next time you have idle

Jack-Works · 2024-04-24T15:26:36Z

packages/web3-providers/src/Store/index.ts

@@ -0,0 +1,21 @@
+import { type StoreAPI } from '../types/Store.js'
+
+export abstract class StoreProvider<T> implements StoreAPI.Provider<T> {


in case you're referring to React's API (which also has a getSnapshot), you cannot store mutable objects in it, or you have to do a full-clone in the getSnapshot

It's consumed by useExternalStore. I stored an instance of this class, which is created once and doesn't change. The one thing that might break the rule is that the instance contains a mutable map. However, since this is used internally, I think it's fine.

The one thing that might break the rule is that the instance contains a mutable map.

well, this is wrong.

getSnapshot() { return structuredClone(this.store) }

you can do this, if this.store does not store a custom class. things like Map<string, string> is ok

So each time the getSnapshot() is invoked, a new instance of Store class should be returned?

So each time the getSnapshot() is invoked, a new instance of Store class should be returned?

No, it should return what it stored. The store itself is untouched.

* chore: bump version to 2.25.0 * fix: setting list (#11556) * fix: swap page in dark mode (#11555) * fix: bugfix for swap settings list * fix: scroll * chore: replace lens profile link (#11557) * fix: replace lens profile link * chore: name * fix: remove edit profile * fix: swap get gas alert (#11559) * fix: conflict * fix: scroll and metis token value (#11584) * fix: mf-6168 reset connection error (#11579) * fix: bugfix for exchange ui (#11586) * fix: selecting token from other chain set it to native token (#11587) * fix: mf-6195 selecting token from other chain set it to native token * fix: mf-6193 background of redpacket history * fix: repalce lens link (#11588) * fix: bugfix for switch logo button (#11589) * refactor: avatar plugin (#11473) * refactor: avatar refactor: remove unused components chore: tidy up components refactor: store helpers chore: impl store refactor: avatar components refactor: cleanup types refactor: remove mobile sniffing * fix: eslint * refactor: cleanup * refactor: code style * fix: smoke testing * fix: warning * fix: test case * fix: eslint --------- Co-authored-by: guanbinrui <guanbinrui@users.noreply.github.com> * fix: mf-6201 crash caused by mui (#11592) * fix: missing chain (#11593) * fix: set max number for chain select (#11595) * fix: invoke redpacket parsing api on Firefly only (#11594) * fix: profile avatar (#11596) * fix: profile avatar * fix: lint error * fix: mf-6200 nft avatar decoration (#11598) * chore: add lens handle name fallback (#11601) * fix: uniq binding account (#11602) * chore: lock file --------- Co-authored-by: nuanyang233 <nuanyang233@gmail.com> Co-authored-by: Jack Works <jackworks@protonmail.com> Co-authored-by: Wukong Sun <158803171+swkatmask@users.noreply.github.com> Co-authored-by: guanbinrui <guanbinrui@users.noreply.github.com>

guanbinrui added this to the 2.24.6 milestone Mar 2, 2024

guanbinrui force-pushed the refactor/avatar-plugin branch 12 times, most recently from d428df5 to 282baaa Compare March 9, 2024 03:42

guanbinrui force-pushed the refactor/avatar-plugin branch 5 times, most recently from 7f93455 to 0d8282a Compare March 9, 2024 12:33

Base automatically changed from hotfix/2.24.6 to released March 29, 2024 07:09

refactor: avatar

11f7c46

refactor: remove unused components chore: tidy up components refactor: store helpers chore: impl store refactor: avatar components refactor: cleanup types refactor: remove mobile sniffing

guanbinrui force-pushed the refactor/avatar-plugin branch from 1c065bb to 11f7c46 Compare April 24, 2024 12:51

guanbinrui changed the base branch from released to release/2.25.0 April 24, 2024 12:51

guanbinrui and others added 3 commits April 24, 2024 12:54

fix: eslint

0587dfe

refactor: cleanup

c026f04

refactor: code style

c1d890c

guanbinrui marked this pull request as ready for review April 24, 2024 14:53

fix: smoke testing

9769cda

guanbinrui force-pushed the refactor/avatar-plugin branch from 4d9641f to 9769cda Compare April 24, 2024 14:54

Jack-Works reviewed Apr 24, 2024

View reviewed changes

fix: warning

fcd627d

guanbinrui force-pushed the refactor/avatar-plugin branch from 5757282 to fcd627d Compare April 24, 2024 15:20

Jack-Works reviewed Apr 24, 2024

View reviewed changes

fix: test case

8d7b46e

guanbinrui force-pushed the refactor/avatar-plugin branch from b1e5cb3 to 8d7b46e Compare April 24, 2024 16:37

fix: eslint

a1ee925

guanbinrui merged commit d6e59ec into release/2.25.0 Apr 24, 2024
3 checks passed

guanbinrui deleted the refactor/avatar-plugin branch April 24, 2024 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: avatar plugin #11473

refactor: avatar plugin #11473

guanbinrui commented Mar 2, 2024 •

edited by jira bot

Jack-Works Apr 24, 2024

guanbinrui Apr 24, 2024

Jack-Works Apr 24, 2024

guanbinrui Apr 24, 2024

Jack-Works Apr 24, 2024

guanbinrui Apr 24, 2024 •

edited

Jack-Works Apr 25, 2024

Jack-Works Apr 24, 2024

guanbinrui Apr 24, 2024

Jack-Works Apr 24, 2024

guanbinrui Apr 24, 2024 •

edited

Jack-Works Apr 25, 2024

		const indexOf = url.indexOf('?')
		return url.slice(0, Math.max(0, indexOf === -1 ? url.length : indexOf))

		@@ -0,0 +1,21 @@
		import { type StoreAPI } from '../types/Store.js'

		export abstract class StoreProvider<T> implements StoreAPI.Provider<T> {

refactor: avatar plugin #11473

refactor: avatar plugin #11473

Conversation

guanbinrui commented Mar 2, 2024 • edited by jira bot

Description

Type of change

Previews

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guanbinrui Apr 24, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guanbinrui Apr 24, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guanbinrui commented Mar 2, 2024 •

edited by jira bot

guanbinrui Apr 24, 2024 •

edited

guanbinrui Apr 24, 2024 •

edited