Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: exchange #11501

Merged
merged 9 commits into from Mar 20, 2024
Merged

feat: exchange #11501

merged 9 commits into from Mar 20, 2024

Conversation

nuanyang233
Copy link
Collaborator

Description

Closes #MF-5735

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@nuanyang233 nuanyang233 added this to the 2.25.0 milestone Mar 15, 2024
Jack-Works
Jack-Works requested changes Mar 18, 2024
View reviewed changes
Copy link
Member

@Jack-Works Jack-Works left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add comments to patches/README.md

packages/mask/.webpack/config.ts Outdated Show resolved Hide resolved
@nuanyang233 nuanyang233 marked this pull request as ready for review March 19, 2024 05:39
@guanbinrui guanbinrui merged commit 8ee90fe into develop Mar 20, 2024
14 checks passed
@guanbinrui guanbinrui deleted the feat/exchange branch March 20, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-Works Jack-Works Jack-Works requested changes

@guanbinrui guanbinrui guanbinrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.25.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nuanyang233 @Jack-Works @guanbinrui