Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: popup swap page #11513

Merged
merged 8 commits into from Mar 25, 2024
Merged

feat: popup swap page #11513

merged 8 commits into from Mar 25, 2024

Conversation

nuanyang233
Copy link
Collaborator

Description

Closes #MF-6123 MF-5736 MF-6125 MF-6126

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@nuanyang233 nuanyang233 added this to the 2.25.0 milestone Mar 22, 2024
@nuanyang233 nuanyang233 marked this pull request as draft March 22, 2024 12:22
cspell.json Outdated Show resolved Hide resolved
@nuanyang233 nuanyang233 marked this pull request as ready for review March 25, 2024 05:48
@nuanyang233 nuanyang233 added this pull request to the merge queue Mar 25, 2024
Merged via the queue into develop with commit 6725e8d Mar 25, 2024
14 checks passed
@nuanyang233 nuanyang233 deleted the fix/swap-page branch March 25, 2024 11:39
Comment on lines +16 to +17
<Route
path="/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you only have one path, why do you need a router?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants