fix: mf-6133 get token balance on Conflux #11524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swkatmask
force-pushed
the
fix/mf-6133-conflux
branch
4 times, most recently
from
b52dacc
to
7893af2
Compare
guanbinrui
reviewed
Mar 26, 2024
| const entities: Array<[string, string]> = [] | ||
|
|
||
| if (listOfAddress.some(isNativeTokenAddress)) { | ||
| entities.push([NATIVE_TOKEN_ADDRESS ?? '', await this.getBalance(options.account, options)]) | ||
| } | ||
| const BALANCE_CHECKER_ADDRESS = getEthereumConstant(options.chainId, 'BALANCE_CHECKER_ADDRESS') | ||
| if (!BALANCE_CHECKER_ADDRESS) { | ||
| if (process.env.NODE_ENV === 'development') { |
There was a problem hiding this comment.
We could build it in those constant helpers
There was a problem hiding this comment.
It depends. Not all constant variables need to be checked.
There was a problem hiding this comment.
Got it. We can impl this if we need in the future.
swkatmask
force-pushed
the
fix/mf-6133-conflux
branch
from
7893af2
to
7b9e1b9
Compare
guanbinrui
approved these changes
Mar 26, 2024
guanbinrui
pushed a commit
that referenced
this pull request
Mar 27, 2024
guanbinrui
added a commit
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mask.atlassian.net/browse/mf-6133