-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to mui-v5.0.0-alpha.5 #1510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Jack-Works
force-pushed
the
feature/upgrade-to-mui-v5
branch
2 times, most recently
from
September 4, 2020 08:36
8ee1d22
to
57e1cb3
Compare
|
Ok I figure out why the test failed. The ClickAwayListener seems doesn't work well... |
Jack-Works
force-pushed
the
feature/upgrade-to-mui-v5
branch
from
September 8, 2020 08:20
40cbe09
to
7de93de
Compare
IMO it's ready for review @guanbinrui @septs |
Jack-Works
force-pushed
the
feature/upgrade-to-mui-v5
branch
from
September 9, 2020 05:46
c8c3548
to
2fbb621
Compare
guanbinrui
added a commit
that referenced
this pull request
Sep 9, 2020
* feat: upgrade to mui-v5.0.0-alpha.5 * fix: remove hacks about elements * chore: hide metamask on app * refactor: clean up jss related hacks * chore: unlock parse of file service metadata on mobile * fix: menus failed to load * fix: e2e selector * fix: post inspector and replace accidentally sharing the same mount point * chore: reduce warnings and uncaught errors * feat: ensure all react render in the same shadow root share the same JSS instance Co-authored-by: guanbinrui <guanbinrui@dimension.im>
guanbinrui
added a commit
that referenced
this pull request
Sep 12, 2020
* feat: upgrade to mui-v5.0.0-alpha.5 * fix: remove hacks about elements * chore: hide metamask on app * refactor: clean up jss related hacks * chore: unlock parse of file service metadata on mobile * fix: menus failed to load * fix: e2e selector * fix: post inspector and replace accidentally sharing the same mount point * chore: reduce warnings and uncaught errors * feat: ensure all react render in the same shadow root share the same JSS instance Co-authored-by: guanbinrui <guanbinrui@dimension.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot upgrade higher than alpha 5 (iamhosseindhv/notistack#295)
We need the upgrade to at least alpha 4 cause alpha 4 improve usage with StrictMode
This PR also removes some hacks on the ShadowRoot or getComputedStyles to be more compatible with webextension shim.
One thing we need to care about is a breaking change in mui-v5.0.0-alpha4. It drops the use of React.findDOMNode so it becomes more strict on the ref forwarding and we need to check if our code is broken.