Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to mui-v5.0.0-alpha.5 #1510

Merged
merged 10 commits into from
Sep 9, 2020

Conversation

Jack-Works
Copy link
Member

@Jack-Works Jack-Works commented Sep 2, 2020

We cannot upgrade higher than alpha 5 (iamhosseindhv/notistack#295)

We need the upgrade to at least alpha 4 cause alpha 4 improve usage with StrictMode

This PR also removes some hacks on the ShadowRoot or getComputedStyles to be more compatible with webextension shim.

One thing we need to care about is a breaking change in mui-v5.0.0-alpha4. It drops the use of React.findDOMNode so it becomes more strict on the ref forwarding and we need to check if our code is broken.

  • [core] Drop support for non-ref-forwarding class components (#21811) @eps1lon
    Support for non-ref-forwarding class components in the component prop or as an immediate children has been dropped. If you were using unstable_createStrictModeTheme or didn't see any warnings related to findDOMNode in React.StrictMode then you don't need to do anything.
    Otherwise check out the "Caveat with refs" section in our composition guide to find out how to migrate.
    This change affects almost all components where you're using the component prop or passing children to components that require children to be elements (e.g. <MenuList><CustomMenuItem /></MenuList>)

@Jack-Works Jack-Works marked this pull request as draft September 2, 2020 09:22
@Jack-Works Jack-Works force-pushed the feature/upgrade-to-mui-v5 branch 2 times, most recently from 8ee1d22 to 57e1cb3 Compare September 4, 2020 08:36
@Jack-Works
Copy link
Member Author

    ✓ backup file - db_backup_0_persona_0_profile (4752 ms)
    ✓ backup file - db_backup_1_persona_0_profile (6754 ms)
    ✕ backup file - db_backup_1_persona_1_profile (34709 ms)
    ✕ backup file - db_backup_2_personas_0_profile (34716 ms)
    ✕ backup file - db_backup_2_personas_2_profiles (34720 ms)
    ✕ backup file - db_backup_0_persona_0_profile (34704 ms)
    ✕ backup file - db_backup_1_persona_0_profile (34705 ms)
    ✕ backup file - db_backup_1_persona_1_profile (34732 ms)
    ✕ backup file - db_backup_2_personas_0_profile (34728 ms)
    ✕ backup file - db_backup_2_personas_2_profiles (34732 ms)

@Jack-Works Jack-Works marked this pull request as ready for review September 4, 2020 09:57
@Jack-Works
Copy link
Member Author

Ok I figure out why the test failed. The ClickAwayListener seems doesn't work well...

@Jack-Works
Copy link
Member Author

IMO it's ready for review @guanbinrui @septs

@Jack-Works Jack-Works changed the base branch from master to hotfix/1.15.3 September 9, 2020 05:42
@guanbinrui guanbinrui merged commit fb845bf into hotfix/1.15.3 Sep 9, 2020
@guanbinrui guanbinrui deleted the feature/upgrade-to-mui-v5 branch September 9, 2020 06:11
guanbinrui added a commit that referenced this pull request Sep 9, 2020
* feat: upgrade to mui-v5.0.0-alpha.5

* fix: remove hacks about elements

* chore: hide metamask on app

* refactor: clean up jss related hacks

* chore: unlock parse of file service metadata on mobile

* fix: menus failed to load

* fix: e2e selector

* fix: post inspector and replace accidentally sharing the same mount point

* chore: reduce warnings and uncaught errors

* feat: ensure all react render in the same shadow root share the same JSS instance

Co-authored-by: guanbinrui <guanbinrui@dimension.im>
guanbinrui added a commit that referenced this pull request Sep 12, 2020
* feat: upgrade to mui-v5.0.0-alpha.5

* fix: remove hacks about elements

* chore: hide metamask on app

* refactor: clean up jss related hacks

* chore: unlock parse of file service metadata on mobile

* fix: menus failed to load

* fix: e2e selector

* fix: post inspector and replace accidentally sharing the same mount point

* chore: reduce warnings and uncaught errors

* feat: ensure all react render in the same shadow root share the same JSS instance

Co-authored-by: guanbinrui <guanbinrui@dimension.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants