New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use swc to replace ts-loader #3512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
guanbinrui,
jk234ert,
septs and
zhouhanseng
June 27, 2021 16:21
himself65
previously approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
github-actions
bot
added
Blocked: Has Conflict
and removed
Blocked: Has Conflict
labels
Jul 14, 2021
@DimensionDev/dev-maskbook review this |
plz resolve conflicts |
github-actions
bot
added
Blocked: Has Conflict
and removed
Blocked: Has Conflict
labels
Jul 21, 2021
septs
approved these changes
Jul 26, 2021
himself65
approved these changes
Jul 26, 2021
yanzhihong23
added a commit
that referenced
this pull request
Jul 27, 2021
* develop: fix: absence account (#3752) feat: use swc to replace ts-loader (#3512) Revert "feat: enable es2020 syntax (#3750)" (#3758) feat: upgrade to holoflows-kit 0.9.0 (#3756) fix: type error (#3757) feat: enable es2020 syntax (#3750) refactor: remove ancient features (#3746) refactor: enhance robustness (#3664) chore: add isValidChainId (#3749) chore: update compatibility (#3747) fix: zerion with polygon & bsc (#3738) fix: the color of text placeholder (#3740) refactor: let SearchIcon inherit color from style context (#3735) chore: the default trending data provider (#3739)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance change on my machine: (Both are measured with webpack file system cache).
If someone has a slow PC, please test this!
Build twice (to create webpack file system cache) on ffc76d1 and measure the time, then build twice on 782f85b and measure the time