Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use swc to replace ts-loader #3512

Merged
merged 10 commits into from Jul 26, 2021
Merged

feat: use swc to replace ts-loader #3512

merged 10 commits into from Jul 26, 2021

Conversation

Jack-Works
Copy link
Member

@Jack-Works Jack-Works commented Jun 27, 2021

Performance change on my machine: (Both are measured with webpack file system cache).

  • ts-loader: 14.5s(dev) 20.8s(prod) 4s(hmr)
  • swc-loader: 11.5s(dev) 19.6s(prod) 4s(hmr)

If someone has a slow PC, please test this!

Build twice (to create webpack file system cache) on ffc76d1 and measure the time, then build twice on 782f85b and measure the time

himself65
himself65 previously approved these changes Jun 28, 2021
Copy link
Member

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Jack-Works
Copy link
Member Author

@DimensionDev/dev-maskbook review this

@nuanyang233
Copy link
Collaborator

plz resolve conflicts

@Jack-Works Jack-Works merged commit 0130b75 into develop Jul 26, 2021
@Jack-Works Jack-Works deleted the swc branch July 26, 2021 10:57
yanzhihong23 added a commit that referenced this pull request Jul 27, 2021
* develop:
  fix: absence account (#3752)
  feat: use swc to replace ts-loader (#3512)
  Revert "feat: enable es2020 syntax (#3750)" (#3758)
  feat: upgrade to holoflows-kit 0.9.0 (#3756)
  fix: type error (#3757)
  feat: enable es2020 syntax (#3750)
  refactor: remove ancient features (#3746)
  refactor: enhance robustness (#3664)
  chore: add isValidChainId (#3749)
  chore: update compatibility (#3747)
  fix: zerion with polygon & bsc (#3738)
  fix: the color of text placeholder (#3740)
  refactor: let SearchIcon inherit color from style context (#3735)
  chore: the default trending data provider (#3739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants