Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: internalSend #8338

Merged
merged 20 commits into from Dec 27, 2022
Merged

refactor: internalSend #8338

merged 20 commits into from Dec 27, 2022

Conversation

guanbinrui
Copy link
Member

@guanbinrui guanbinrui commented Dec 22, 2022 •
edited

Description

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2022 •
edited

🚀 Deployed on https://63aa7818ceb41a25ea00d302--compassionate-northcutt-326a3a.netlify.app

@github-actions github-actions bot temporarily deployed to pull request December 22, 2022 15:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 22, 2022 15:37 Inactive
@guanbinrui guanbinrui added this to the 2.17.0 milestone Dec 22, 2022
@github-actions github-actions bot temporarily deployed to pull request December 22, 2022 15:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 22, 2022 15:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 22, 2022 16:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 23, 2022 04:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 23, 2022 04:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 26, 2022 07:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 26, 2022 07:31 Inactive
@guanbinrui guanbinrui marked this pull request as ready for review December 26, 2022 07:50
@github-actions github-actions bot temporarily deployed to pull request December 26, 2022 07:51 Inactive
@guanbinrui
refactor: dup sign method
8ca1c84 
eth_sign & personal_sign are the same algorithms since they generate the same result

learn more:
+ https://gist.github.com/miguelmota/f75be1de350a0196db4a90cc96a5505f
+ WalletConnect/walletconnect-monorepo#1395
@github-actions github-actions bot temporarily deployed to pull request December 26, 2022 14:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 26, 2022 15:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 26, 2022 15:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 27, 2022 04:36 Inactive
@guanbinrui guanbinrui merged commit f618cc3 into develop Dec 27, 2022
@guanbinrui guanbinrui deleted the refactor/popups-send branch December 27, 2022 04:39
@github-actions github-actions bot temporarily deployed to pull request December 27, 2022 04:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@guanbinrui