Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add hub getFungibleToken #8479

Merged
merged 3 commits into from Jan 13, 2023
Merged

refactor: add hub getFungibleToken #8479

merged 3 commits into from Jan 13, 2023

Conversation

zhouhanseng
Copy link
Contributor

Description

https://mask.atlassian.net/browse/MF-3201

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@zhouhanseng zhouhanseng added this to the 2.17.0 milestone Jan 13, 2023
@guanbinrui guanbinrui merged commit 2cf6ea9 into release/2.17.0 Jan 13, 2023
@guanbinrui guanbinrui deleted the rp-description branch January 13, 2023 08:24
UncleBill added a commit that referenced this pull request Jan 13, 2023
@UncleBill
fix: mf-3201 fixup! refactor: add hub getFungibleToken (#8479)
2ba3cc2
UncleBill added a commit that referenced this pull request Jan 13, 2023
@UncleBill
fix: mf-3218 fixup! refactor: add hub getFungibleToken (#8479)
0d2477d
UncleBill added a commit that referenced this pull request Jan 14, 2023
@UncleBill
fix: mf-3218 fixup! refactor: add hub getFungibleToken (#8479)
b9fc659
guanbinrui pushed a commit that referenced this pull request Jan 14, 2023
@UncleBill
fix: mf-3218 fixup! refactor: add hub getFungibleToken (#8479) (#8492)
e92482a
guanbinrui pushed a commit that referenced this pull request Jan 15, 2023
@UncleBill @guanbinrui
fix: mf-3218 fixup! refactor: add hub getFungibleToken (#8479) (#8492)
1db9192
guanbinrui pushed a commit that referenced this pull request Jan 16, 2023
@zhouhanseng @guanbinrui
refactor: add hub getFungibleToken (#8479)
b41d9ac 
* refactor: add hub getFungibleToken

* chore: remove useless code

* chore: remove useless code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guanbinrui guanbinrui guanbinrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhouhanseng @guanbinrui