Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove gas options in luckdrop #8496

Merged
merged 2 commits into from Jan 14, 2023

Conversation

nuanyang233
Copy link
Collaborator

@nuanyang233 nuanyang233 commented Jan 14, 2023

Description

Closes #MF-3233

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@nuanyang233 nuanyang233 changed the base branch from develop to release/2.17.0 January 14, 2023 08:56
@nuanyang233 nuanyang233 changed the title fix: emove gas options in luckdrop fix: remove gas options in luckdrop Jan 14, 2023
@guanbinrui guanbinrui added this to the 2.17.0 milestone Jan 14, 2023
@guanbinrui guanbinrui merged commit 35faf1c into release/2.17.0 Jan 14, 2023
@guanbinrui guanbinrui deleted the fix/remove-gas-options-in-luckdrop branch January 14, 2023 09:03
guanbinrui pushed a commit that referenced this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants