Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Intermittent IllegalStateException #180

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

tttcowan
Copy link

@tttcowan tttcowan commented Jun 1, 2022

Guard against IllegalStateException caused by adding backgroundView to blurView when it already has a parent. This seems to be an intermittent problem I picked up from Crashlytics.

@tttcowan tttcowan changed the title Fix : Intermittent IllegalStateException Fix: Intermittent IllegalStateException Jun 1, 2022
@tttcowan
Copy link
Author

tttcowan commented Jun 1, 2022

image

@Dimezis
Copy link
Owner

Dimezis commented Jun 1, 2022

Thanks, I'll release it when I'm back from holidays

Dimezis added a commit that referenced this pull request Jun 14, 2022
…ffectBlur is used.

This should significantly improve the performance.
Now always downscaling the RenderNode in RenderEffectBlur by 2x.
RenderEffectBlur is completely rewritten and no longer accepts RenderEffectPrecision.
RenderEffectPrecision is removed.
Fix a crash in RenderEffectBlur - #180
@Dimezis Dimezis merged commit 9d7a593 into Dimezis:master Jun 14, 2022
@Dimezis
Copy link
Owner

Dimezis commented Jun 14, 2022

I released 2.0.1, but after some consideration, I'd advise to not use RenderEffectBlur at the moment.
It causes a constant BlurView redrawing which adds a big overhead.
I'll keep investigating how to improve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants