Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix security author authenticity #66

Conversation

fabiooshiro
Copy link

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Main update on the:

  • api
  • frontend
  • lib

@DimiMikadze
Copy link
Owner

Hi @fabiooshiro, thanks for the PR, but I don't understand how these changes will prevent a hacker from posting a comment with the different user names?

To prevent it, I think will need to check if author and authUser.id are the same, and create a comment only if they are.

@fabiooshiro
Copy link
Author

fabiooshiro commented Sep 5, 2020 via email

@DimiMikadze
Copy link
Owner

DimiMikadze commented Sep 7, 2020

Hi @fabiooshiro, in the issue you have explained that post creation contains a bug, but this PR contains the changes for comments.

As explained in CONTRIBUTING.md let's first discover what's causing the issue, and describe it by respecting the issue template.

Then agree on how we are going to approach it, and finally create a PR.

@DimiMikadze DimiMikadze closed this Sep 7, 2020
@fabiooshiro fabiooshiro deleted the bugfix/comment-security-author-id branch September 7, 2020 15:12
@fabiooshiro
Copy link
Author

All the system has the same problem...

@fabiooshiro fabiooshiro restored the bugfix/comment-security-author-id branch September 9, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants