Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in SPARQL for 1hop-2i/0qual #1

Closed
Kelaproth opened this issue Aug 9, 2022 · 2 comments
Closed

bug in SPARQL for 1hop-2i/0qual #1

Kelaproth opened this issue Aug 9, 2022 · 2 comments

Comments

@Kelaproth
Copy link

It looks like the SPARQL is not executable. should line 37 in test/validation and line 22 in train:
FILTER ((?s1 != ?o2_s0) || (?s1 = ?o2_s0 && str(?p0)< str(?1) ))
be
FILTER ((?s1 != ?o2_s0) || (?s1 = ?o2_s0 && str(?p0)< str(?p1) ))
?

@miselico
Copy link
Collaborator

miselico commented Sep 1, 2022

Yes, you are right.

If you want to generate your own queries, I'd suggest looking into https://github.com/miselico/graph_query_sampler which has better support for query generation with other datasets.

miselico added a commit that referenced this issue Sep 1, 2022
miselico added a commit that referenced this issue Sep 1, 2022
Correction for #1
@miselico
Copy link
Collaborator

miselico commented Sep 1, 2022

Fixed, thanks. Note: i think that this mistake in the formula never affects the generated queries.

@miselico miselico closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants