Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: completion time #17

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

gf3
Copy link
Contributor

@gf3 gf3 commented Jun 18, 2024

This PR adds support for optionally including completion time as well as a handful of settings to configure the functionality of the plugin.

The new settings include:

  • Task markers - Task markers to use (default: "DONE, NOW, LATER, DOING, TODO, WAITING")
  • Include date? - Optionally include date (default: true)
  • Completed date property - Property to use for completed date (default: "completed")
  • Include time? - Optionally include time (default: false)
  • Completed time property - Property to use for completed date (default: "time")
  • Time format - Time format when including time (default: HH:mm)

image

I've also updated the dependencies and tidied up the build a bit (no more html).

And lastly, I've added a dev container configuration which includes all the dependencies necessary to develop this plugin.

@DimitryDushkin
Copy link
Owner

Hey @gf3 ! Thanks a lot for such a great contribution! I removed files related to your personal dev env if you don't mind.

@DimitryDushkin DimitryDushkin merged commit 2b333ec into DimitryDushkin:main Jun 18, 2024
@DimitryDushkin DimitryDushkin removed their request for review June 18, 2024 18:46
@gf3 gf3 deleted the feat/completion-time branch June 18, 2024 18:46
@gf3
Copy link
Contributor Author

gf3 commented Jun 18, 2024

@DimitryDushkin sure thing! however, the dev container config makes it easy for others to automatically have a working environment to hack on this plugin. see:

@DimitryDushkin
Copy link
Owner

@DimitryDushkin
Copy link
Owner

@DimitryDushkin sure thing! however, the dev container config makes it easy for others to automatically have a working environment to hack on this plugin. see:

Yeah, it looks cool. But sorry I'm not super familiar with devcontainers so I'm not able to review this correctly.

@DimitryDushkin
Copy link
Owner

DimitryDushkin commented Jun 18, 2024

And it's not working. I forgot that Logseq actually not working when loaded just JS file. It always needs to load html. See logseq/logseq#10117

@DimitryDushkin
Copy link
Owner

Updated build. Now it's working out of marketplace again.

@gf3 thanks again for the contribution. If you will have a moment could you take a look at settings update issue? Settings are not applied unless you restart the app now.

@gf3
Copy link
Contributor Author

gf3 commented Jun 19, 2024

@DimitryDushkin i will have a look, thanks for the fixes. i didn't realize there was an issue with loading JS files directly in non-developer mode. my apologies for the breakage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants