Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix indent and codestyle #8

Merged
merged 1 commit into from Jan 22, 2016
Merged

fix indent and codestyle #8

merged 1 commit into from Jan 22, 2016

Conversation

zebapy
Copy link
Contributor

@zebapy zebapy commented Jan 22, 2016

Removed some tab characters and fixed spacing around props.

I'd recommend just sticking to no spaces around prop values (prop={something}) as that's more common, even if objects outside of JSX have spaces. It's an exception – just like using double quotes in JSX.

Also I noticed elsewhere that there is a mixture of self-closed components ending with a space before /> (this file) and some without the space (the server file).

I did this edit on Github so I'm not sure if the lint config specifies that or not.

Removed some tab characters and fixed spacing around props. 

I'd recommend just sticking to no spaces around prop values (`prop={something}`) as that's more common, even if objects outside of JSX have spaces. It's an exception – just like using double quotes in JSX.
@Dindaleon
Copy link
Owner

That is weird, it doesn't look like that on my editor. I am using Sublime Text. What do you think it might be causing it?

Thanks for pointing it out and fixing it. Are there other files with the same problem?

I do have lint configured to have spaces inside curly braces and parenthesis. I do not plan to change this as of now, but I will consider it for future releases.

The self closing components should all have an space before />
I see where doesn't have the space in the server file:

renderToString( <Html store={ store }/> )

Please let me know if there are more files missing the space.

I will fix it now.

Dindaleon added a commit that referenced this pull request Jan 22, 2016
fix indent and codestyle
@Dindaleon Dindaleon merged commit d6521c3 into Dindaleon:master Jan 22, 2016
@zebapy
Copy link
Contributor Author

zebapy commented Jan 22, 2016

@Dindaleon I think you can set tabs display as a specific amount of spaces in some text editors. That's my only thought.

@Dindaleon
Copy link
Owner

Well, I will keep an eye open for future versions. I have mine set to two spaces indent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants