Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve the documentation #183

Merged
merged 11 commits into from
Jan 8, 2022
Merged

docs: improve the documentation #183

merged 11 commits into from
Jan 8, 2022

Conversation

flexagoon
Copy link
Contributor

The Teledart documentation is currently very lacking (see #181). This PR attempts to improve the documentation to make it more clear and complete.

@flexagoon flexagoon marked this pull request as ready for review December 1, 2021 08:53
@flexagoon
Copy link
Contributor Author

@DinoLeung the PR is done!

@DinoLeung DinoLeung changed the base branch from master to develop January 8, 2022 05:45
Copy link
Owner

@DinoLeung DinoLeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you hard work, I can tell you have spent massive amount of time working on this. Much appreciated. Minor issue I have picked up, but I will fix it in a different PR just to save us time.

@@ -269,14 +336,22 @@ class TeleDart {
caption_entities: caption_entities,
duration: duration,
performer: performer,
title: title,
thumb: thumb,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unintentional i believe

@DinoLeung DinoLeung merged commit 567c627 into DinoLeung:develop Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants