fix(build): add asset to github release #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svnv
force-pushed
the
fix-github-release-add-build
branch
from
a5bab91
to
19b92b2
Compare
frodeaa
approved these changes
Feb 23, 2024
andersem
approved these changes
Feb 23, 2024
|
🎉 This PR is included in version 0.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Feb 26, 2024
svnv
added a commit
that referenced
this pull request
Feb 27, 2024
Fixes #331 Ref. #330 Rel. semantic-release/npm#535 Rel. https://github.com/Dintero/Dintero.Checkout.Web.SDK/actions/runs/8045967660/job/21972265552 The previous config change did not work as intended. The npm plugin for semantic release seems to be running twice and the .tgz is not present in the dist folder, and from the logs it does not even look like the package created contains the actual build files either. Instead of trying to make sense of the npm plugin we try using the exec plugin to run npm pack before the github plugin creates is release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. https://dintero.slack.com/archives/G7ESUNQ0Z/p1708678043060989
Change configuration for
semantic-release. With these changes wenpmandgithubplugins (not sure if needed but it matches the order of when they have an effect better)npmplugin configuration so that the tarball fromnpm packis added to the dist foldergithubplugin configuration with anassetentry that takes all tarballs in the dist folderSee related example in the docs for the npm plugin here https://github.com/semantic-release/npm?tab=readme-ov-file#examples
Docs: