This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
feat: add "--open" option to dioxus serve
#136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arqalite
changed the title
dioxus serve
arqalite
changed the title
dioxus serve
arqalite
changed the title
dioxus serve
mrxiaozhuox
approved these changes
May 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "--open" CLI parameter to the "serve" option, allowing the CLI to open the app in the user's default browser.
dioxus serve --openwill open the app in the default browser.dioxus serve --open --hot-reloadwill do the same, but with hot-reloading active.This is just a nice-to-have feature that Trunk has and that I kind of miss since switching to Dioxus CLI.
This may introduce a bug in certain systems where the browser starts too early and times out as the server hasn't finished starting, meaning the user will have to manually refresh once the server starts.
A fix would involve starting the server, then probing the URL to see what response it returns before actually opening the browser (but that would require spawning a separate process/thread and adding too much complexity IMO, but let me know if you want me to add this.)