Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx allows keys with non-dynamic contents #1809

Closed
jkelleyrtp opened this issue Jan 11, 2024 · 0 comments · Fixed by #2016
Closed

rsx allows keys with non-dynamic contents #1809

jkelleyrtp opened this issue Jan 11, 2024 · 0 comments · Fixed by #2016
Labels
tweak Small changes to improve experience

Comments

@jkelleyrtp
Copy link
Member

Problem

Just an easy thing we should deny in the rsx! macro. Right now we let you put

div {
    key: "idx"
}

which will just break your app. This should just not compile - you shouldn't ever have static keys.

@ealmloff ealmloff added the tweak Small changes to improve experience label Jan 11, 2024
@jkelleyrtp jkelleyrtp added this to the 0.5.0: Signals milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tweak Small changes to improve experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants