Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add note about form prevent_default behavior. #1343

Merged
merged 2 commits into from Aug 17, 2023
Merged

DOC: Add note about form prevent_default behavior. #1343

merged 2 commits into from Aug 17, 2023

Conversation

vgobbo
Copy link
Contributor

@vgobbo vgobbo commented Aug 12, 2023

Starting on version 0.4 (PR #926), the prevent_default behavior inverted for forms in dioxus-web. This just adds a note to the documentation to document this.

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@ealmloff ealmloff enabled auto-merge (squash) August 17, 2023 12:56
@ealmloff ealmloff merged commit 8946944 into DioxusLabs:master Aug 17, 2023
2 checks passed
@arqalite
Copy link
Contributor

arqalite commented Aug 19, 2023

IMO this needs to be added to the public documentation ASAP, it's a breaking change that will cause issues for anyone trying to port their apps from 0.3 to 0.4.

(I may or may not have spent an entire hour wondering why all my forms started going crazy)

@vgobbo vgobbo deleted the feat-prevent_default-behavior branch August 19, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants