Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary protocol for desktop and liveview #1534

Merged
merged 26 commits into from Jan 4, 2024

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Oct 9, 2023

Closes #695

  • Integrate sledgehammer with liveview
  • Restore mounted event liveview
  • Restore eval liveview
  • Integrate sledgehammer with desktop
  • Restore mounted event desktop
  • Restore eval desktop
  • Evaluate rendering performance and latency

@ealmloff ealmloff added enhancement New feature or request desktop Suggestions related to the desktop renderer liveview Related to the liveview renderer performance labels Oct 9, 2023
@ealmloff ealmloff added the breaking This is a breaking change label Oct 17, 2023
@ealmloff
Copy link
Member Author

ealmloff commented Oct 20, 2023

Liveview

Time to render 10000 rows initially:

  • Old: 15-18ms
  • New: 10ms

Time to update 10000 rows:

  • Old: 3ms
  • New: 2ms

Static page/JS size:

  • Old: 26kb
  • New: 15kb

Size of message to render 10000 rows initially:

  • Old: 1429kb
  • New: 360kb

Size of message to update 10000 rows:

  • Old: 534kb
  • New: 220kb

Desktop

Time to render 10000 rows initially:

  • Old: 40ms latency + 50ms scripting
  • New: 10ms latency + 15ms scripting

Time to update 10000 rows:

  • Old: 15ms latency + 15ms scripting
  • New: 6ms latency + 3ms scripting

Old:

Screen_Recording_2023-10-17_at_2.41.42_PM.mov

New:

Screen_Recording_2023-10-17_at_2.40.40_PM.mov

@ealmloff ealmloff marked this pull request as ready for review October 20, 2023 18:21
@jkelleyrtp jkelleyrtp added this to the 0.5 Release milestone Oct 25, 2023
@jkelleyrtp jkelleyrtp merged commit 70ff508 into DioxusLabs:master Jan 4, 2024
0 of 4 checks passed
@ealmloff ealmloff deleted the binary-protocal branch January 4, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This is a breaking change desktop Suggestions related to the desktop renderer enhancement New feature or request liveview Related to the liveview renderer performance
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use sledgehammer in Desktop and LiveView
2 participants