Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out CLI configs into a separate library #1622

Merged
merged 23 commits into from Jan 8, 2024

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Nov 8, 2023

This PR pulls out the CLI config into a separate library so that we can more easily integrate the config into internal libraries that need to read the config at runtime during dev mode. In the future this will let us read something like the assets path that is supplied in the config inside of the fullstack crate to serve the correct assets in both web and fullstack mode. Overall this will result in less duplication between configuration in code and configuration in the Dioxus.toml format

closes #1564

@ealmloff ealmloff added cli Related to the dioxus-cli program tweak Small changes to improve experience labels Nov 8, 2023
@ealmloff ealmloff marked this pull request as draft November 8, 2023 18:52
@ealmloff ealmloff marked this pull request as ready for review November 9, 2023 14:58
@ealmloff
Copy link
Member Author

We need to expose const access to the cli config so that the parts of the config we need are baked into the binary at compile time. I am marking this as a draft again until that is added

@ealmloff ealmloff marked this pull request as draft November 10, 2023 22:51
@ealmloff ealmloff marked this pull request as ready for review November 15, 2023 14:23
@ealmloff
Copy link
Member Author

That makes the base_url from Dioxus.toml work in the router and the app title from Dioxus.toml work in desktop apps automatically

@ealmloff ealmloff added this to the 0.5.0: Signals milestone Nov 21, 2023
@jkelleyrtp jkelleyrtp merged commit 399e20f into DioxusLabs:master Jan 8, 2024
9 of 10 checks passed
@ealmloff ealmloff deleted the cli-config-library branch January 8, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the dioxus-cli program tweak Small changes to improve experience
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Integrate base_url with the router
2 participants