Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1623 #1626

Merged
merged 1 commit into from Nov 9, 2023
Merged

Fix 1623 #1626

merged 1 commit into from Nov 9, 2023

Conversation

tigerros
Copy link
Contributor

@tigerros tigerros commented Nov 9, 2023

See #1623. This just allows the warning where it should be allowed.

@tigerros tigerros changed the title Allow warning in necessary functions Fix 1623 Nov 9, 2023
@tigerros tigerros mentioned this pull request Nov 9, 2023
Closed
4 tasks
ealmloff
ealmloff approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ealmloff ealmloff merged commit d4b0451 into DioxusLabs:master Nov 9, 2023
10 checks passed
@tigerros tigerros deleted the fix-1623 branch November 9, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealmloff ealmloff ealmloff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tigerros @ealmloff