Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add into attribute value impl for String #1651

Merged
merged 1 commit into from Dec 7, 2023

Conversation

ealmloff
Copy link
Member

This makes it possible to pass string directly into an attribute. String is a very common type and this is something I have seen people hit several times when they first use dioxus.

@ealmloff ealmloff added core relating to the core implementation of the virtualdom tweak Small changes to improve experience labels Nov 19, 2023
@rambip
Copy link

rambip commented Nov 23, 2023

I do agree, I had to find very ellaborate workarounds to solve this issue.

In particular, rsx!{div {style: "{1}"}} does work but rsx! {div {style: format!("{1}")}} doesn't.

I is not user-friendly at all

@jkelleyrtp jkelleyrtp merged commit 850f2da into DioxusLabs:master Dec 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core relating to the core implementation of the virtualdom tweak Small changes to improve experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants