Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disconnects that happen while a server function is being resolved #1698

Merged
merged 1 commit into from Dec 7, 2023
Merged

Fix disconnects that happen while a server function is being resolved #1698

merged 1 commit into from Dec 7, 2023

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Dec 7, 2023

When a server function is called, but then the client disconnect, the oneshot channel send panics. This PR fixes that issue by joining the task instead

@ealmloff ealmloff added bug Something isn't working fullstack related to the fullstack crate labels Dec 7, 2023
jkelleyrtp
jkelleyrtp approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@jkelleyrtp jkelleyrtp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point it might be nice to set up test harnesses for stuff like this.

@jkelleyrtp jkelleyrtp merged commit 424926a into DioxusLabs:master Dec 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkelleyrtp jkelleyrtp jkelleyrtp approved these changes

Assignees
No one assigned
Labels
bug Something isn't working fullstack related to the fullstack crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ealmloff @jkelleyrtp