Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dx create not work #1709

Merged
merged 1 commit into from Dec 11, 2023
Merged

fix: dx create not work #1709

merged 1 commit into from Dec 11, 2023

Conversation

mrxiaozhuox
Copy link
Member

Because the get_bin function will use cargo_metadata, but for some command we don't have it.

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

The code for the plugin system here is kind of messy. All of it should be configged out, but it isn't related to this change. I can fix it in the plugins PR.

@ealmloff ealmloff merged commit 695bf00 into DioxusLabs:master Dec 11, 2023
10 checks passed
@ealmloff ealmloff added the bug Something isn't working label Dec 11, 2023
@mrxiaozhuox
Copy link
Member Author

Thank you!

The code for the plugin system here is kind of messy. All of it should be configged out, but it isn't related to this change. I can fix it in the plugins PR.

because you are working for new plugin system, I think you will rewrite some part, so I didn't change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants