Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error log when root element isn't found #1724

Merged
merged 1 commit into from Dec 15, 2023
Merged

add error log when root element isn't found #1724

merged 1 commit into from Dec 15, 2023

Conversation

w3irdrobot
Copy link
Contributor

closes #1231

@ealmloff
Copy link
Member

It looks like we only enable the console feature of web-sys here if the hydrate feature is enabled. The workspace has that feature enabled, so I don't think the issue will show up in CI, but we need to add it to the list of web-sys features that are always enabled here

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make a missing root id much easier to debug. Thank you!

@ealmloff ealmloff merged commit 2321c1a into DioxusLabs:master Dec 15, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web: Error when Dioxus fails to mount to the real dom
2 participants