Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): added multiple nested errors support #1880

Merged
merged 1 commit into from Jan 30, 2024

Conversation

Andrew15-5
Copy link
Contributor

Before the top-level error message would print the dependent error message. Now multiple nested errors can be shown (with anyhow context).

Example (for demonstrative purposes only):

Before:

Error: 馃毇 Serving project failed: Couldn't copy the server binary from "/tmp/fullstack/.dioxus/ssr/debug/fullstack" to "/tmp/fullstack/dist/fullstack". Maybe the server process (fullstack) wasn't killed and is still running.

After:

Error: 馃毇 Serving project failed:

Caused by:
    0: Couldn't copy the server binary from "/tmp/fullstack/.dioxus/ssr/debug/fullstack" to "/tmp/fullstack/dist/fullstack". Maybe the server process (fullstack) wasn't killed and is still running.
    1: Text file busy (os error 26)

Before the top-level error message would print the dependent error
message. Now multiple nested errors can be shown (with anyhow context).
Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those errors look much easier to debug, thank you!

@ealmloff ealmloff merged commit c518c91 into DioxusLabs:master Jan 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants