Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix child routers with the web history #2172

Merged
merged 2 commits into from
Mar 30, 2024

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Mar 28, 2024

Followup to #2159

This PR fixes an error that happens when a child field is used with the web router in the docsite. It currently triggers an unused field error even though the child field is used

(NOTE: the child attribute is not currently a public API and is intentionally undocumented)

@ealmloff ealmloff added bug Something isn't working router Related to the router implementation labels Mar 28, 2024
@ealmloff ealmloff changed the title Fix child fields with the web history Fix child routers with the web history Mar 28, 2024
@jkelleyrtp jkelleyrtp merged commit 9f280a8 into DioxusLabs:main Mar 30, 2024
1 check passed
@ealmloff ealmloff deleted the fix-unused-child-field-error branch March 30, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working router Related to the router implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants