Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out of order fields in route definitions #2356

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

ealmloff
Copy link
Member

This PR fixes parsing for routes that have fields in the route string in a different order than they were defined in the enum variant

Fixes #2353

@ealmloff ealmloff added bug Something isn't working router Related to the router implementation labels Apr 22, 2024
@jkelleyrtp jkelleyrtp merged commit 39cef8f into DioxusLabs:main Apr 25, 2024
9 checks passed
@ealmloff ealmloff deleted the route-order-enum-router branch April 25, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working router Related to the router implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route order matters between url string and enum fields
2 participants