Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt a fix for:
rustflags
in./cargo/config.toml
being ignored #2366There's a few ways we can fix this:
I implemented the first approach before thinking about the other three. In reality not passing our own flags is probably for the best. I didn't realize cargo rustc doesn't impact dependencies so I'm not sure if our flags will actually make a difference if used that way.
The config override might be better, but I'd rather the other sources of flags be the override instead of us.