Fix task dead cancelation race condition #2444
Open
+208
−164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2440 is caused by restarting a future that has already finished. Something like this was happening:
TaskId(0)
)TaskId(0)
)TaskId(0)
TaskId(0)
which we are currently in was already recycled so the new future is again spawned inTaskId(0)
TaskId(0)
TaskId(0)
has already been dropped so it is never polledThis PR fixes that issue by switching the resource's task to None when the future is finished. It also applies the fix to use_future and use_coroutine.
Fixes #2440