Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add PWA w/ Dioxus CLI template #977

Merged
merged 2 commits into from
Apr 23, 2023
Merged

examples: add PWA w/ Dioxus CLI template #977

merged 2 commits into from
Apr 23, 2023

Conversation

arqalite
Copy link
Contributor

This closes #414.

I added a PWA template that uses Dioxus CLI, with a functioning service worker and manifest. The PWA supports cache, is installable and works offline (provided that the user adds the project files in the service worker JS file when creating their project).

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You! This mostly looks good, just a few issues getting it to integrate with CI correctly. Because this is a full package example, I think we need to add it to the workspace here so that the CI will compile and lint it

examples/PWA-example/Cargo.toml Outdated Show resolved Hide resolved
@ealmloff ealmloff merged commit 459d8d6 into DioxusLabs:master Apr 23, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

any pwa example?
2 participants