Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update examples #29

Merged
merged 5 commits into from
Apr 3, 2024
Merged

fix: Update examples #29

merged 5 commits into from
Apr 3, 2024

Conversation

marc2332
Copy link
Collaborator

@marc2332 marc2332 commented Apr 1, 2024

Closes #28

@marc2332 marc2332 added the fix label Apr 1, 2024
@marc2332 marc2332 marked this pull request as draft April 1, 2024 20:34
@marc2332 marc2332 changed the title fix: Update launch in examples fix: Update launch method in examples Apr 1, 2024
@marc2332 marc2332 changed the title fix: Update launch method in examples fix: Update examples Apr 1, 2024
DogeDark
DogeDark approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@DogeDark DogeDark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far.

@marc2332 marc2332 marked this pull request as ready for review April 3, 2024 20:46
@DogeDark DogeDark merged commit 8e83eaf into DioxusLabs:master Apr 3, 2024
4 checks passed
@DogeDark
Copy link
Member

DogeDark commented Apr 3, 2024

Thanks! We'll ignore that geolocation is too fast for Dioxus, for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DogeDark DogeDark DogeDark approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clipboard example broken
2 participants
@marc2332 @DogeDark