-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trampoline child measurement/layout through the LayoutTree
trait
#427
Trampoline child measurement/layout through the LayoutTree
trait
#427
Conversation
4adf897
to
e427cf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems solid to me.
I think it would be great to add a simple example demonstrating how to use these new capabilities, if possible.
This would make it easier to detect limitations of the approach and also serve as a useful reference to library authors to integrate this.
Yes, it's strange that this doesn't affect any of our examples, which means our examples are lacking. |
This API was never really properly designed/launched. It was introduced as part of a PR which was necesary for refactoring Flexbox to interop with CSS Grid. One of my main aims for Taffy 0.4 is to sort this out and make this API useful. |
Objective
The objective here it to make is easy to embed Taffy as part of a larger layout implementation rather than usage of Taffy requiring you to "buy in" to having all your layouting needs handled by Taffy.
This is the core change from #326
Fixes #28
Context
See #28 (comment)
Notes
Seems to be relatively perf-neutral.