Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use --enable-blink-features=NewFlexboxSizing when running gentests #433

Closed

Conversation

nicoburns
Copy link
Collaborator

@nicoburns nicoburns commented Apr 11, 2023

Objective

Chrome has a new in-development flexbox engine. Analysis of the results using the new engine suggest that it's results are more sensible than the current engines (although only 4 tests differ). This PR enables the new engine in the gentest script by using the command line flag --enable-blink-features=NewFlexboxSizing.

TODO: Fix broken tests.

Context

@nicoburns nicoburns added bug Something isn't working testing Additional tests or improvements to the testing infrastructure labels Apr 11, 2023
@nicoburns
Copy link
Collaborator Author

Status update:

  • 1 test was fixed by this change
  • 1 test broke and I've fixed it by removing a quirk in our code
  • 1 test broke, but I think that it's a bug in Chrome's new engine (submitted to chrome here https://bugs.chromium.org/p/chromium/issues/detail?id=240765#c47)
  • 2 tests broke, and fixing them is going to be a bit of work as requires us to have the ability to compute that content size of nodes that have an explicit size set which we don't currently support for nodes other than leaf nodes.

@nicoburns
Copy link
Collaborator Author

I've talked with some Chrome developers, and it turns out that:

I'm going to close this for now and look into this again once Chrome/Firefox have stable shipping implementations (which may be within the next few weeks).

@nicoburns nicoburns closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Additional tests or improvements to the testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant