Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't return TaffyResult when Taffy methods can't fail. #520

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Don't return TaffyResult when Taffy methods can't fail. #520

wants to merge 8 commits into from

Commits on Jul 20, 2023

  1. Don't return TaffyResult when Taffy methods can't fail. 

    Initial commit for: DioxusLabs#519.

Affected methods:

`new_leaf`, `compute_layout`, `new_leaf_with_measure`,
`new_with_children`, `remove`, `set_measure`, `add_child`,
`set_children`, `child_count`, `children`, `layout`, `set_style`,
`style`, `mark_dirty`, `dirty`.

Should be noted that many of the methods can still panic due to the
frequent use of direct array indexing.
    @gibbz00
    gibbz00 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    45f1a9e View commit details
    Browse the repository at this point in the history

  2. Clippy linting.

    @gibbz00
    gibbz00 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    7622c32 View commit details
    Browse the repository at this point in the history

  3. CONTRIBUTING.md: Add RUST_LOG instructions.

    @gibbz00
    gibbz00 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    9c33153 View commit details
    Browse the repository at this point in the history

  4. Remove unwraps in generated tests. 

    Accompanies: 4a9ac5e
    @gibbz00
    gibbz00 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    c007e55 View commit details
    Browse the repository at this point in the history

  5. Remove unwraps in README.md. 

    Accompanies: 4a9ac5e
    @gibbz00
    gibbz00 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    703908d View commit details
    Browse the repository at this point in the history

  6. Add breaking unwrap removal changes to RELEASES.md

    @gibbz00
    gibbz00 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    11e5b52 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Remove unwraps in benches. 

    Accompanies: 4a9ac5e
    @gibbz00
    gibbz00 committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    45af6f1 View commit details
    Browse the repository at this point in the history

  2. Fix RELEASES markdown linting.

    @gibbz00
    gibbz00 committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    d8a934b View commit details
    Browse the repository at this point in the history