Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy/Paste Across World 1.16.4 #551

Closed
GamingFanatics opened this issue Nov 25, 2020 · 13 comments
Closed

Copy/Paste Across World 1.16.4 #551

GamingFanatics opened this issue Nov 25, 2020 · 13 comments
Assignees
Labels
1.16 bug Something isn't working oversight Overlooked functionality, but not necessarily a bug

Comments

@GamingFanatics
Copy link

In version 3.7.2 (Latest) gives an error of "Paste Failed, MC Version (1.12.x) is not supported. Please use only templates that were buid for the current version (1.16.4)." However, it was copied from another world in the same instance without even closing the game. That being 1.16.4.

@hvdklauw
Copy link
Contributor

Thanks for the report, if you have the file for me that would really help.

I'll have a look at it

@hvdklauw
Copy link
Contributor

Yeah, I'll need more information, it works for me, having the template itself would really help but also blocks used etc.

@MichaelHillcox
Copy link
Collaborator

The odd thing is that error should only ever show if you read code that is able to be parsed by the nbt string reader which should only work on 1.12. This was an intentional move to try and make it clear on what versions work on what mod versions

https://github.com/Direwolf20-MC/BuildingGadgets/blob/master/src/main/java/com/direwolf20/buildinggadgets/client/screen/TemplateManagerGUI.java#L622

@GamingFanatics
Copy link
Author

Actually, I did some tests, it was only because the world I was using to build stuff in was created in 1.12, however, I have just been copying it every version so I do not know if that's suppose to be how it is if the world was created in a past version, or what. But as far as I can tell that was my issue.

@GamingFanatics
Copy link
Author

Nevermind, I tried it in my survival world and it still gave me the error. Here is a Pastebin for the copy. https://pastebin.com/rtmaXPem

@hvdklauw
Copy link
Contributor

Thank you, looking at the file everything seems to be correct , I'll do debugging tonight

@MichaelHillcox
Copy link
Collaborator

Okay, something is wrong with the error but I actually know what the root cause of this issue is, I forgot to update the template header java class to be 1.16.4.

MichaelHillcox added a commit that referenced this issue Nov 25, 2020
@MuteTiefling
Copy link

I was running into this tonight and was about to open a ticket when I found this. Out of curiosity, I tried updating the headers in my exported templates and they still were not importing.

Basic Fission Reactor.txt

Not sure if it's just the header change or if something will change on the 'read' end when this is pushed?

@hvdklauw
Copy link
Contributor

hvdklauw commented Dec 1, 2020

The problem is part the header not being updated and part the copy part not copying correctly.

I'll have a look today at the code, there where issues with engineer's decor catwalks too.

@MuteTiefling
Copy link

Per our quick chat on discord, here are the rest of the templates in case it helps: https://gist.github.com/MuteTiefling/5a8b425273a1008c0163b786b8780ba4

@hvdklauw
Copy link
Contributor

hvdklauw commented Dec 1, 2020

Tested them, those all work with the fix I have ready, they load, paste and form a multiblock!

@hvdklauw
Copy link
Contributor

hvdklauw commented Dec 1, 2020

fixed with #554

@MichaelHillcox MichaelHillcox added 1.16 bug Something isn't working oversight Overlooked functionality, but not necessarily a bug pending release These changes have not yet been released in a build labels Dec 20, 2020
@MichaelHillcox MichaelHillcox self-assigned this Dec 20, 2020
@MichaelHillcox MichaelHillcox removed the pending release These changes have not yet been released in a build label Feb 15, 2021
@StarkGER
Copy link

I ran into the same problem just now and it really bothers me. I found a template for 1.12.x and the author cnverted it to 1.16.x. (I'm playing ATM6 btw on a server, if that's relevant) The header looks exactly like other templates and the rest too seems to be exaclty the same. It's a 37x37 sth structure and has only vanila blocks. But yet, trying to paste it onto a piece of paper, it give me "failed to paste Template to clipboard" and i can't get a hold of it why this is the case. Can you help me out here?

Mentioned template code ist this one, with the version changed to mine (1.16.5): https://gist.github.com/moomoo84/46e5d4c10b5b34f858f5dfd3054e7bb4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.16 bug Something isn't working oversight Overlooked functionality, but not necessarily a bug
Projects
None yet
Development

No branches or pull requests

5 participants