Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from netcoreapp3.0 to net5.0-windows #214

Merged
merged 2 commits into from
Apr 5, 2021

Conversation

mgnslndh
Copy link
Contributor

@mgnslndh mgnslndh commented Dec 1, 2020

This PR aims to migrate Dirkster.AvalonDock from targetting netcoreapp3.0 to net5.0 and net5.0-windows.

Fixes #213

The first step of changing target framework is done and everything seems to work. However there are lots of warnings and I have not yet checked if they are present in netcoreapp3.0. We might want to do more maintenance work.

Let me know what you think when you have tried it out.

@eriove
Copy link
Contributor

eriove commented Dec 2, 2020

Great work. I'm another user of AvalonDock. We are currently using netcoreapp3.0. Would it be possible to keep that target at least for a while? We plan to upgrade but haven't had time yet.

@mgnslndh
Copy link
Contributor Author

mgnslndh commented Dec 2, 2020

I have no problem with keeping the old net core target platform. Will bring it back in.

@Dirkster99
Copy link
Owner

Same here, I have no problem with more than 2 target frameworks either (other than increased complexity, more compiling time and larger nuget packages) but we should move out of netcore at some point, maybe in one year, or so?

But right now I am seeing only 2 frameworks eg:

Am I looking in the wrong place or are you not yet finished bringing the netcore stuff back in again?

@mgnslndh
Copy link
Contributor Author

mgnslndh commented Dec 5, 2020

Right, I have not adde back netcoreapp yet. Hopefully i will do it over the weekend.

@mgnslndh
Copy link
Contributor Author

@eriove @Dirkster99 I have now added netcoreapp3.0 back in.

@mgnslndh mgnslndh changed the title WIP: Migrate from netcoreapp3.0 to net5.0-windows Migrate from netcoreapp3.0 to net5.0-windows Dec 29, 2020
@Dirkster99 Dirkster99 merged commit 5f3f915 into Dirkster99:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET 5.0
3 participants