Fixed a bug that freezed when changing DocumentPane Orientation #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirkster99
added a commit
that referenced
this pull request
Jan 13, 2021
|
Hi Sukamoni I had to undo your PR because I found through testing that it seems to introduce new issues - I started the MLibTest Tool and used the below workflow and ended in a crash which did not appear without your PR :-( Would you be able to review this crash and maybe do a bit more testing before trying to apply this fix again?
|
|
Hi Dirkster99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dropping a DoucumentPane onto another DoucumentPane, the process freezes under certain condition
Occurs in the following situations
It seems to be an old problem, and that part has been fixed