Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commented check in LayoutAnchorable Hide method #32

Merged
merged 1 commit into from
May 21, 2019

Conversation

gpetrou
Copy link

@gpetrou gpetrou commented May 17, 2019

No description provided.

@Dirkster99
Copy link
Owner

Hi, thanks a lot for the pull request - I'd realy like to merge it into the code and release a new version but I need to better understand what the problem is that we are fixing. I could off course be going off and be doing guess work but I prefer communication :-)

Would you be able to give me a short description for this fix? It would, for example, be enough if you give me a short list of test steps and an expectation to verify how the software behaves with and without your fix.

Thanks Dirk

@gpetrou
Copy link
Author

gpetrou commented May 17, 2019

Sorry, I should have added some description.
I did not find a bug, but while looking at the code for something else, I noticed that inside the brackets we have Parent as ILayoutGroup and then access IndexOfChild. Unless I am mistaken and Parent as ILayoutGroup is guaranteed to not return null?

@Dirkster99 Dirkster99 merged commit 324875c into Dirkster99:master May 21, 2019
@Dirkster99
Copy link
Owner

You are correct with your analysis - but what about my analysis over in #33 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants