Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix enumerateDevices + refactoring + improvements #13

Merged
merged 17 commits into from
Aug 15, 2021

Conversation

miroslavpejic85
Copy link
Contributor

@miroslavpejic85 miroslavpejic85 commented Jul 22, 2021

fix enumerateDevices - Ref: #12
refactoring + improve UI using bootstrap & fontawesome:

Join

join

Room

room

Video border

room-video


Logs output:

log-refactoring


Update dependencies - 0 vulnerabilities

update-dependencies


Add prettier as default code formatter

prettier-code-formatter

    "devDependencies": {
        "prettier": "2.3.2"
    }

Update README

pull-requests

@miroslavpejic85 miroslavpejic85 changed the title fix enumerateDevices fix enumerateDevices + refactoring Jul 26, 2021
@Dirvann
Copy link
Owner

Dirvann commented Aug 3, 2021

Thanks for the contribution!
Just some suggestions
how about the prettier with this configuration:

module.exports= {
  semi: false,                              // supported with node and lighter on the eyes
  trailingComma: 'none',
  printWidth: 120,
  tabWidth: 2
}

Also the package-lock.json shouldn't be removed as it contains the exact versions of the packages to be installed.

@Dirvann
Copy link
Owner

Dirvann commented Aug 3, 2021

I will also not be very active this half of August as I have other things I'm currently busy with

@miroslavpejic85 miroslavpejic85 changed the title fix enumerateDevices + refactoring fix enumerateDevices + refactoring + improvements Aug 3, 2021
@miroslavpejic85
Copy link
Contributor Author

miroslavpejic85 commented Aug 3, 2021

Thanks for the contribution!
Just some suggestions
how about the prettier with this configuration:

module.exports= {
  semi: false,                              // supported with node and lighter on the eyes
  trailingComma: 'none',
  printWidth: 120,
  tabWidth: 2
}

Also the package-lock.json shouldn't be removed as it contains the exact versions of the packages to be installed.

Hi @Dirvann, My pleasure!
If you prefer that config, that’s fine, ;) It was just a personal choice 🙂
Regarding package-lock.json sorry, so I need to keep this current that I have now, or do I have to keep only some parts?
One question: where can I find mediasoupclient.min.js last version? This is 3.6.12.
Thanks & keep in touch.

@Dirvann
Copy link
Owner

Dirvann commented Aug 4, 2021

Thanks for the response.
Yeah you can just put your package-lock.json if the application still works with it. And regarding the mediasoupclient.min.js I compiled it myself using browserify.

@miroslavpejic85
Copy link
Contributor Author

miroslavpejic85 commented Aug 4, 2021

But what I see, the package-lock.json is generated differently depending on whether they are on the mac or Linux OS ...
As I can see yours is like on my Linux OS :) For this reason I put it on .gitignore So that when one runs npm install it will create their own package-lock.json file depending on the OS, or I'm doing something wrong? :) Anyway, in Both MAC-LINUX works well. Regarding browserify I'm trying something like this:

browserify node_modules/mediasoup-client/lib/index.js -o mediasoupclient.min.js

But from what I've seen, you've edited this part as well : https://github.com/Dirvann/mediasoup-sfu-webrtc-video-rooms/blob/master/public/modules/mediasoupclient.min.js#L10129

Thanks to you, my pleasure to meet you.

@Dirvann Dirvann merged commit 4aaf5cb into Dirvann:master Aug 15, 2021
@Dirvann Dirvann mentioned this pull request Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants