-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix enumerateDevices + refactoring + improvements #13
Conversation
Thanks for the contribution!
Also the package-lock.json shouldn't be removed as it contains the exact versions of the packages to be installed. |
I will also not be very active this half of August as I have other things I'm currently busy with |
Hi @Dirvann, My pleasure! |
Thanks for the response. |
But what I see, the package-lock.json is generated differently depending on whether they are on the mac or Linux OS ... browserify node_modules/mediasoup-client/lib/index.js -o mediasoupclient.min.js But from what I've seen, you've edited this part as well : https://github.com/Dirvann/mediasoup-sfu-webrtc-video-rooms/blob/master/public/modules/mediasoupclient.min.js#L10129 Thanks to you, my pleasure to meet you. |
fix enumerateDevices
- Ref: #12refactoring + improve UI
using bootstrap & fontawesome:Join
Room
Video border
Logs output:
Update dependencies -
0 vulnerabilities
Add prettier as default code formatter
Update README