Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Commit

Permalink
Angular 10 (#100)
Browse files Browse the repository at this point in the history
* chore(Angular): Updated to Version 10

* chore(ngx-bootbstrap): Removed ngx-bootstrap as dependency as it is unused

* chore(typeahead): typeahead removed / fixed peer deps
  • Loading branch information
Disane87 committed Dec 17, 2020
1 parent 0791ada commit 1f8c518
Show file tree
Hide file tree
Showing 4 changed files with 40 additions and 32 deletions.
5 changes: 3 additions & 2 deletions projects/ngx-taskboard-lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@
"tslib": "^2.0.0"
},
"peerDependencies": {
"@angular/common": "^7.2.0",
"@angular/core": "^7.2.0"
"@angular/common": ">=7.2.0",
"@angular/core": ">=7.2.0",
"bootstrap":">=4.5.3"
}
}
60 changes: 35 additions & 25 deletions projects/ngx-taskboard-lib/src/lib/board/board.component.spec.ts
Original file line number Diff line number Diff line change
@@ -1,32 +1,42 @@
import { async, ComponentFixture, inject, TestBed } from '@angular/core/testing';

import { FormsModule } from '@angular/forms';
import { FaIconLibrary, FontAwesomeModule } from '@fortawesome/angular-fontawesome';
import { BoardComponent } from './board.component';


import { fab } from '@fortawesome/free-brands-svg-icons';
import { far } from '@fortawesome/free-regular-svg-icons';
import { fas } from '@fortawesome/free-solid-svg-icons';

import { FilterSearchBarComponent } from '../filter-search-bar/filter-search-bar.component';
import { TaskboardService } from '../taskboard.service';

import {FontAwesomeTestingModule} from '@fortawesome/angular-fontawesome/testing';
import { TypeaheadModule } from 'ngx-bootstrap/typeahead';
import { OutSideEventHandlerDirective } from '../directives/outside-event-handler.directive';

describe('MyLibComponent', () => {
import {
async,
ComponentFixture,
inject,
TestBed,
} from "@angular/core/testing";

import { FormsModule } from "@angular/forms";
import {
FaIconLibrary,
FontAwesomeModule,
} from "@fortawesome/angular-fontawesome";
import { BoardComponent } from "./board.component";

import { fab } from "@fortawesome/free-brands-svg-icons";
import { far } from "@fortawesome/free-regular-svg-icons";
import { fas } from "@fortawesome/free-solid-svg-icons";

import { FilterSearchBarComponent } from "../filter-search-bar/filter-search-bar.component";
import { TaskboardService } from "../taskboard.service";

import { FontAwesomeTestingModule } from "@fortawesome/angular-fontawesome/testing";
// import { TypeaheadModule } from 'ngx-bootstrap/typeahead';
import { OutSideEventHandlerDirective } from "../directives/outside-event-handler.directive";

describe("MyLibComponent", () => {
let component: BoardComponent;
let fixture: ComponentFixture<BoardComponent>;

beforeEach(async(() => {
TestBed.configureTestingModule({
declarations: [BoardComponent, FilterSearchBarComponent, OutSideEventHandlerDirective],
imports: [FontAwesomeTestingModule, FormsModule, TypeaheadModule],
providers: [TaskboardService]
})
.compileComponents();
declarations: [
BoardComponent,
FilterSearchBarComponent,
OutSideEventHandlerDirective,
],
imports: [FontAwesomeTestingModule, FormsModule],
providers: [TaskboardService],
}).compileComponents();
}));

beforeEach(() => {
Expand All @@ -42,7 +52,7 @@ describe('MyLibComponent', () => {
// expect(library.addIconPacks(far)).toHaveBeenCalled();
// }));

it('should create', () => {
it("should create", () => {
expect(component).toBeTruthy();
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,4 @@
</div>
</div> -->
</div>
</div>

<!-- [typeahead]="taskboardService.objectProperties" -->
</div>
3 changes: 1 addition & 2 deletions projects/ngx-taskboard-lib/src/lib/ngx-taskboard.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,13 @@ import { fas } from '@fortawesome/free-solid-svg-icons';
import { FilterSearchBarComponent } from './filter-search-bar/filter-search-bar.component';
import { TaskboardService } from './taskboard.service';

import { TypeaheadModule } from 'ngx-bootstrap/typeahead';
import { OutSideEventHandlerDirective } from './directives/outside-event-handler.directive';

// library.add(fas, far, fab);

@NgModule({
declarations: [BoardComponent, FilterSearchBarComponent, OutSideEventHandlerDirective],
imports: [BrowserModule, FontAwesomeModule, FormsModule, TypeaheadModule.forRoot(), BrowserAnimationsModule],
imports: [BrowserModule, FontAwesomeModule, FormsModule, BrowserAnimationsModule],
providers: [TaskboardService],
exports: [BoardComponent]
})
Expand Down

0 comments on commit 1f8c518

Please sign in to comment.