[DSCP-351] improve keygen commands #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martoon-00
force-pushed
the
martoon/dscp351-improve-keygen-commands
branch
from
b06995b
to
b9256a5
Compare
Martoon-00
changed the title
volhovm
reviewed
Nov 2, 2018
tools/src/keygen/KeygenOptions.hs
Outdated
| @@ -32,7 +31,7 @@ secretDataTypeParser = asum | |||
| , CommSecret <$> option auto | |||
| (long "comm-sec" <> | |||
| metavar "N" <> | |||
| help "Use given committee secret and derive secret key of N-th \ | |||
| help "Use giencodeIntegerven committee secret and derive secret key of N-th \ | |||
There was a problem hiding this comment.
You've mistakenly inserted encodeInteger in the middle of the other word.
tools/src/keygen/KeygenOptions.hs
Outdated
|
|
||
| , command "student-submission" $ info | ||
| (fmap PrintStudentSubmission . strOption $ | ||
| long "seed" <> |
There was a problem hiding this comment.
Is there any other way to solve this?
There was a problem hiding this comment.
I extracted that parser and one below, if you were talking about it.
volhovm
approved these changes
Nov 3, 2018
Martoon-00
force-pushed
the
martoon/dscp351-improve-keygen-commands
branch
from
6ef1591
to
bec5a87
Compare
Martoon-00
force-pushed
the
martoon/dscp351-improve-keygen-commands
branch
from
bec5a87
to
b5411d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves keygen interface. Adds help messages for each command of the keygen.
For instance:
dscp-keygen --seed --command "address:hex"->dscp-keygen --seed address --hex.YT issue
https://issues.serokell.io/issue/DSCP-351
Checklist
Hint: a perfect PR has all the checkmarks set.
Possible related changes (conditional):
Stylistic (obligatory):