Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update javadocs, and add missing Intents #1107

Merged
merged 2 commits into from Jan 30, 2023
Merged

Conversation

j0rdanit0
Copy link
Sponsor Contributor

Description:
The Intents enum is out of date. The following changes have been made:

  • Some javadocs were modified to reference additional gateway events.
  • GUILD_EMOJIS is now GUILD_EMOJIS_AND_STICKERS, so GUILD_EMOJIS was marked as @Deprecated to preserve backwards compatibility, and GUILD_EMOJIS_AND_STICKERS was added with the same shift count.
  • The following new values were added:
    • MESSAGE_CONTENT(15)
    • GUILD_SCHEDULED_EVENTS(16)
    • AUTO_MODERATION_CONFIGURATION(20)
    • AUTO_MODERATION_EXECUTION(21)

Justification:
To match the current set of Intents described here: https://discord.com/developers/docs/topics/gateway#list-of-intents

*
* @see <a href="https://discord.com/developers/docs/topics/gateway#message-content-intent">Message Contnet Intent</a>
*/
MESSAGE_CONTENT(15),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will setting this new intent resolve message events appearing with empty content?

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Discord docs seem to imply that. And of course, this is a privileged intent, so you'll need to be verified in order to use it if your bot is in more than 100 servers.

@quanticc quanticc changed the base branch from master to 3.2.x January 30, 2023 01:21
@quanticc quanticc changed the base branch from 3.2.x to master January 30, 2023 01:21
@quanticc quanticc changed the base branch from master to 3.2.x January 30, 2023 03:38
@quanticc quanticc added this to the 3.2.4 milestone Jan 30, 2023
@quanticc quanticc added enhancement Improvement over an existing feature area/core Related to core module: events, entities, clients, specs area/gateway Related to the gateway module: websocket, reconnections, payload handling and removed area/core Related to core module: events, entities, clients, specs labels Jan 30, 2023
Copy link
Member

@quanticc quanticc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've changed the base of your PR to the 3.2.x branch

@quanticc quanticc merged commit 3d272dc into Discord4J:3.2.x Jan 30, 2023
quanticc added a commit that referenced this pull request Jan 30, 2023
@j0rdanit0 j0rdanit0 deleted the patch-1 branch April 24, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway Related to the gateway module: websocket, reconnections, payload handling enhancement Improvement over an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants