Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not log reconnect packet received as an error #655

Closed
Shadorc opened this issue Apr 10, 2020 · 0 comments
Closed

Do not log reconnect packet received as an error #655

Shadorc opened this issue Apr 10, 2020 · 0 comments
Labels
area/gateway Related to the gateway module: websocket, reconnections, payload handling enhancement Improvement over an existing feature
Projects
Discord4J v3.0 - v3.1
Milestone
3.1.0.M2

Comments

@Shadorc
Copy link
Contributor

Shadorc commented Apr 10, 2020

Feature Description: Do not log reconnect packet received as an error.

Justification: With the last Discord API updates, we now receive a lot of Gateway client error: discord4j.common.close.CloseException: WebSocket closed: 1006 java.lang.RuntimeException: Reconnecting due to reconnect packet received. These messages are normal, Discord4J should just reconnect as expected. However, they are logged as an error, meaning something went wrong. I think INFO should be more appropriate.
@quanticc quanticc added the area/gateway Related to the gateway module: websocket, reconnections, payload handling label Apr 10, 2020
@quanticc quanticc added this to Backlog in Discord4J v3.0 - v3.1 via automation Apr 10, 2020
@quanticc quanticc added this to the 3.1.0.M2 milestone Apr 10, 2020
@quanticc quanticc added the enhancement Improvement over an existing feature label Apr 10, 2020
@ByteAlex ByteAlex mentioned this issue Apr 23, 2020
Merged
Discord4J v3.0 - v3.1 automation moved this from Backlog to Done Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/gateway Related to the gateway module: websocket, reconnections, payload handling enhancement Improvement over an existing feature
Projects
No open projects
Discord4J v3.0 - v3.1
  
Done
Milestone
3.1.0.M2
Development

No branches or pull requests
2 participants
@quanticc @Shadorc