Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice channel room assertion #59

Closed
Laith98Dev opened this issue Apr 14, 2022 · 7 comments
Closed

Voice channel room assertion #59

Laith98Dev opened this issue Apr 14, 2022 · 7 comments

Comments

@Laith98Dev
Copy link
Contributor

Laith98Dev commented Apr 14, 2022

sometimes it giving this error

Plugin version: 2.1.2
Server version: 4.2.4
PHP version: 8.0.16
Operating system: linux

Error:

 [Server thread/CRITICAL]: AssertionError: "Channel '964259918184079370' shouldn't have room for this member." (EXCEPTION) in "plugins/DiscordBot.phar/src/Plugin/BotCommunicationHandler" at line 182
--- Stack trace ---
  #0 plugins/DiscordBot.phar/src/Plugin/BotCommunicationHandler(105): JaxkDev\DiscordBot\Plugin\BotCommunicationHandler->handleVoiceStateUpdate(object JaxkDev\DiscordBot\Communication\Packets\Discord\VoiceStateUpdate#43870)
  #1 plugins/DiscordBot.phar/src/Plugin/Main(253): JaxkDev\DiscordBot\Plugin\BotCommunicationHandler->handle(object JaxkDev\DiscordBot\Communication\Packets\Discord\VoiceStateUpdate#43870)
  #2 plugins/DiscordBot.phar/src/Plugin/Main(107): JaxkDev\DiscordBot\Plugin\Main->tick(integer 9587)
  #3 pmsrc/src/scheduler/ClosureTask(63): JaxkDev\DiscordBot\Plugin\Main->JaxkDev\DiscordBot\Plugin\{closure}()
  #4 pmsrc/src/scheduler/TaskHandler(117): pocketmine\scheduler\ClosureTask->onRun()
  #5 pmsrc/src/scheduler/TaskScheduler(144): pocketmine\scheduler\TaskHandler->run()
  #6 pmsrc/src/plugin/PluginManager(467): pocketmine\scheduler\TaskScheduler->mainThreadHeartbeat(integer 9587)
  #7 pmsrc/src/Server(1768): pocketmine\plugin\PluginManager->tickSchedulers(integer 9587)
  #8 pmsrc/src/Server(1657): pocketmine\Server->tick()
  #9 pmsrc/src/Server(1046): pocketmine\Server->tickProcessor()
  #10 pmsrc/src/PocketMine(304): pocketmine\Server->__construct(object BaseClassLoader#3, object pocketmine\utils\MainLogger#2, string[9] /root/pk/, string[17] /root/pk/plugins/)
  #11 pmsrc/src/PocketMine(327): pocketmine\server()
  #12 pmsrc(11): require(string[53] phar:///root/pk/PocketMine-MP.phar/src/PocketMine.php)
--- End of exception information ---
[20:41:35.030] [Server thread/EMERGENCY]: An unrecoverable error has occurred and the server has crashed. Creating a crash dump
[20:41:35.045] [Server thread/EMERGENCY]: Please upload the "/root/pk/crashdumps/Thu_Apr_14-20.41.35-UTC_2022.log" file to the Crash Archive and submit the link to the Bug Reporting page. Give as much info as you can.
[20:41:35.411] [Server thread/EMERGENCY]: The crash dump has been automatically submitted to the Crash Archive. You can view it on https://crash.pmmp.io/view/6435441 or use the ID #6435441.
[20:41:35.413] [Server thread/EMERGENCY]: Forcing server shutdown
[20:41:35.413] [Server thread/INFO]: Disabling DiscordBot v2.1.2
[20:41:35.414] [Server thread/INFO]: [DiscordBot] Stopping discord thread gracefully, waiting for discord thread to stop...
[20:41:35.431] [Server thread/INFO]: [DiscordBot] Thread stopped.

crash_dump file
Thu_Apr_14-20.41.35-UTC_2022.log

@Laith98Dev
Copy link
Contributor Author

Laith98Dev commented Apr 16, 2022

It gives this error when the voice channel has more players than the allowed limit

@TukangM

This comment was marked as off-topic.

@JaxkDev
Copy link
Member

JaxkDev commented May 8, 2022

It gives this error when the voice channel has more players than the allowed limit

Well how do you manage that ? (inside discord)

@JaxkDev JaxkDev changed the title Bug Voice channel room assertion May 8, 2022
@Laith98Dev
Copy link
Contributor Author

Laith98Dev commented May 8, 2022

It gives this error when the voice channel has more players than the allowed limit

Well how do you manage that ? (inside discord)

Ok, many of discord servers used temporary channels and when someone make a temporary voice channel and for example sets the users limit 2 and the voice it's full just who have a huge rank can join and when it join, the plugin it giving this problem

@JaxkDev
Copy link
Member

JaxkDev commented May 8, 2022

Ah I see, can reproduce now.
Seems admins/owners (unsure of specific permission required) are allowed to join 'full' voice channels.

@Laith98Dev
Copy link
Contributor Author

yes

JaxkDev added a commit that referenced this issue May 8, 2022
- Closes #59
- Admins(TBC)/Owners can still join regardless of user limit.
@JaxkDev
Copy link
Member

JaxkDev commented May 8, 2022

Fixed, will be in next minor/patch update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants