Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply filter to attachments #1404

Open
1 task done
JinjaFormbi opened this issue May 17, 2022 · 3 comments · May be fixed by #1629
Open
1 task done

Apply filter to attachments #1404

JinjaFormbi opened this issue May 17, 2022 · 3 comments · May be fixed by #1629

Comments

@JinjaFormbi
Copy link

Why?

as seen in issue #1403
"Possible to config certain messages to default ones / remove long discord Picture image link messages inside Minecraft"
Images get send as long text messages.

What and How?

Adding uploaded files to the DiscordChatChannelDiscordFilters

Are there alternatives?

Make a specific function that can filter discord files

Checks

  • I have used the search at least once to check if my idea has already been suggested and perhaps already implemented.

Anything else

thanks to chrissamael for the specification of the problem

@JinjaFormbi
Copy link
Author

Currently if the solution in #1403 is applied the link will be send regardless if the image is uploaded by the poster. the filter dies apply if the poster sends the link to the image.
Both variants of posting are indistinguishable for a user on the discord side on the first glance.

@Dinty1 Dinty1 changed the title Add filter fuction for image Uploads to the discord Client Apply filter to attachments Jun 8, 2022
@GreenGinkgo
Copy link

GreenGinkgo commented Dec 15, 2022

This appears to still be a problem. My hunch is that it might be due to the text being sent in a separate "message" which is not the text of the message a Discord user sends.

It might depend on HOW the link is sent - my test was to copy an image in Windows and paste it while composing a Discord message, which triggers some kind of dynamic upload. I have applied a regex filter to completely wipe out any line that contains "http" and yet file URLs are still sent to chat. See screenshots

image
image
image

@granny
Copy link
Member

granny commented Mar 29, 2024

Should be fixed on latest snapshot builds. https://snapshot.discordsrv.com/

@Dinty1 Dinty1 linked a pull request Mar 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants