Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair obsolete terms in imports #1047

Closed
allenbaron opened this issue Jun 14, 2022 · 7 comments
Closed

Repair obsolete terms in imports #1047

allenbaron opened this issue Jun 14, 2022 · 7 comments
Assignees
Labels
data engineering Indicates code development to improve data/build

Comments

@allenbaron
Copy link
Collaborator

The count of owl:deprecated properties/classes from imports in doid-merged.owl, release v2022-06-07 is:

import deprecated
RO 1
GENO 2
HP 147

These should be reviewed and removed or repaired as necessary.

The deprecated RO & GENO property/classes are:

The deprecated HP classes are listed in the following file: HP_deprecated_v2022-06-07.txt

@allenbaron
Copy link
Collaborator Author

It appears that none of these property/classes are used in any triples in the doid-merged.owl file. They probably just need to be excluded the next time we update these imports.

@allenbaron
Copy link
Collaborator Author

The deprecated HP terms are all defined in the src/ontology/ext.owl file and do not exist in the src/ontology/import/hp_import.owl file.

@allenbaron allenbaron self-assigned this Aug 10, 2022
@lschriml
Copy link
Contributor

@allenbaron - Can we close this ticket ?

@lschriml lschriml added the data engineering Indicates code development to improve data/build label Aug 25, 2022
@allenbaron
Copy link
Collaborator Author

Not yet. None of these deprecated terms have been addressed.

@lschriml
Copy link
Contributor

Can you add an estimate of when this will be addressed or time-frame for this resolution ?

@allenbaron
Copy link
Collaborator Author

allenbaron commented Sep 6, 2022

HP:0011007 has been merged into 'Onset' (HP:0003674) and the class has been completely removed from hp.owl, instead of deprecated, so it can be removed ext.owl.

All of the remaining HP terms are in the hp.owl file and none of those are deprecated.

allenbaron added a commit that referenced this issue Sep 8, 2022
@allenbaron
Copy link
Collaborator Author

The remaining HP deprecation statements have been removed. Closed by b691c5b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data engineering Indicates code development to improve data/build
Projects
None yet
Development

No branches or pull requests

2 participants