Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sensitive fields from report record #440

Merged
merged 1 commit into from Nov 25, 2020

Conversation

stegben
Copy link
Contributor

@stegben stegben commented Nov 22, 2020

把一些最好不要暴露給外界的資料從 API 中拿掉

@stegben stegben requested review from Swind and Yukaii November 22, 2020 07:00
@stegben stegben force-pushed the remove-sensitive-field-from-reportrecord branch from a71dec8 to 5bca087 Compare November 22, 2020 07:09
Copy link
Contributor

@Swind Swind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我後來有稍微測試一下,其實 action_body 裡面也會有暱稱與聯絡資訊。
所以可能連 action_body 都要拿掉,或者看前端需要什麼,調整裡面的內容。

@stegben
Copy link
Contributor Author

stegben commented Nov 22, 2020

@Yukaii 請問前端會拿這個 api 顯示什麼給使用者?

@Yukaii
Copy link
Contributor

Yukaii commented Nov 25, 2020

@stegben 過往的 others 會顯示在前端,其它不用

@stegben stegben force-pushed the remove-sensitive-field-from-reportrecord branch from 5bca087 to 0bb39cc Compare November 25, 2020 11:44
@stegben stegben force-pushed the remove-sensitive-field-from-reportrecord branch from 0bb39cc to a7e37f3 Compare November 25, 2020 11:48
@stegben stegben merged commit 10092a9 into master Nov 25, 2020
@stegben stegben deleted the remove-sensitive-field-from-reportrecord branch November 25, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants